Throw errors when trying to RLP encode integers.

ethers-io · Mar 17, 2020 · 9ea16e5 · 9ea16e5
1 parent 3e44aac
commit 9ea16e5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/bytes/src.ts/index.ts b/packages/bytes/src.ts/index.ts
@@ -97,7 +97,7 @@ export function arrayify(value: BytesLike | Hexable | number, options?: DataOpti
         const result = [];
         while (value) {
             result.unshift(value & 0xff);
-            value /= 256;
+            value = parseInt(String(value / 256));
         }
         if (result.length === 0) { result.push(0); }
 

diff --git a/packages/rlp/src.ts/index.ts b/packages/rlp/src.ts/index.ts
@@ -2,8 +2,7 @@
 
 //See: https://github.com/ethereum/wiki/wiki/RLP
 
-
-import { arrayify, BytesLike, hexlify } from "@ethersproject/bytes";
+import { arrayify, BytesLike, hexlify, isBytesLike } from "@ethersproject/bytes";
 
 function arrayifyInteger(value: number): Array<number> {
     const result = [];
@@ -41,6 +40,10 @@ function _encode(object: Array<any> | string): Array<number> {
 
     }
 
+    if (!isBytesLike(object)) {
+        throw new Error("RLP object must be BytesLike");
+    }
+
     const data: Array<number> = Array.prototype.slice.call(arrayify(object));
 
     if (data.length === 1 && data[0] <= 0x7f) {