Replicated former ENS normalize behaviour for empty strings and updat…

…e namehash testcases.
ethers-io · Oct 11, 2023 · 125ff11 · 125ff11
1 parent bc115a2
commit 125ff11
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/src.ts/hash/namehash.ts b/src.ts/hash/namehash.ts
@@ -44,6 +44,7 @@ function ensNameSplit(name: string): Array<Uint8Array> {
  */
 export function ensNormalize(name: string): string {
     try {
+        if (name.length === 0) { throw new Error("empty label"); }
         return ens_normalize(name);
     } catch (error: any) {
         assertArgument(false, `invalid ENS name (${ error.message })`, "name", name);
@@ -66,6 +67,8 @@ export function isValidName(name: string): name is string {
 export function namehash(name: string): string {
     assertArgument(typeof(name) === "string", "invalid ENS name; not a string", "name", name);
 
+    assertArgument(name.length, `invalid ENS name (empty label)`, "name", name);
+
     let result: string | Uint8Array = Zeros;
 
     const comps = ensNameSplit(name);

diff --git a/testcases/namehash.json.gz b/testcases/namehash.json.gz