Fix: Removing unnecessary initialization

src/BucketRateLimiter.sol

@@ -16,9 +16,6 @@ contract BucketRateLimiter is IRateLimiter, IPausable, Initializable, PausableUp
     BucketLimiter.Limit public limit;
     address public consumer;
 
-    mapping(address => bool) public DEPRECATED_admins;
-    mapping(address => bool) public DEPRECATED_pausers;
-
     mapping(address => BucketLimiter.Limit) public limitsPerToken;
 
     RoleRegistry public roleRegistry; 
@@ -32,19 +29,12 @@ contract BucketRateLimiter is IRateLimiter, IPausable, Initializable, PausableUp
         _disableInitializers();
     }
 
-    function initialize() external initializer {
+    function initialize(address _roleRegistry) external initializer {
         __Pausable_init();
         __Ownable_init();
         __UUPSUpgradeable_init();
 
         limit = BucketLimiter.create(0, 0);
-    }
-
-    function initializeV2dot5(address _roleRegistry) external onlyOwner {
-        require(address(roleRegistry) == address(0x00), "already initialized");
-
-        // TODO: compile list of values in DEPRECATED_pausers to clear out
-        // TODO: compile list of values in DEPRECATED_admins to clear out
         roleRegistry = RoleRegistry(_roleRegistry);
     }
 
@@ -116,4 +106,4 @@ contract BucketRateLimiter is IRateLimiter, IPausable, Initializable, PausableUp
 
     function _authorizeUpgrade(address newImplementation) internal override onlyOwner {}
 
-}
+}

test/BucketRaterLimiter.t.sol

@@ -17,7 +17,7 @@ contract BucketRateLimiterTest is TestSetup {
         BucketRateLimiter impl = new BucketRateLimiter();
         UUPSProxy proxy = new UUPSProxy(address(impl), "");
         limiter = BucketRateLimiter(address(proxy));
-        limiter.initialize();
+        limiter.initialize(address(roleRegistry));
 
         limiter.updateConsumer(owner);
         limiter.setCapacity(200 ether);
@@ -106,8 +106,11 @@ contract BucketRateLimiterTest is TestSetup {
     function test_pauser() public {
         // Test pausing logic with V2.5 upgrade
         setUpTests();
-        vm.prank(limiter.owner());
-        limiter.initializeV2dot5(address(roleRegistry));
+        // deploy a new bucket rate limiter to initialize against the role registry
+        BucketRateLimiter impl = new BucketRateLimiter();
+        UUPSProxy proxy = new UUPSProxy(address(impl), "");
+        limiter = BucketRateLimiter(address(proxy));
+        limiter.initialize(address(roleRegistry));
 
         vm.prank(chad);
         vm.expectRevert(BucketRateLimiter.IncorrectRole.selector);

test/TestSetup.sol

@@ -405,7 +405,7 @@ contract TestSetup is Test {
 
         address impl = address(new BucketRateLimiter());
         bucketRateLimiter = BucketRateLimiter(address(new UUPSProxy(impl, "")));
-        bucketRateLimiter.initialize();
+        bucketRateLimiter.initialize(address(roleRegistry));
         bucketRateLimiter.updateConsumer(address(liquifierInstance));
 
         bucketRateLimiter.setCapacity(40 ether);