Skip to content

Commit

Permalink
Merge pull request #167 from etherfi-protocol/syko/certora/M-09
Browse files Browse the repository at this point in the history
[Certora][M-09] Lack of etherFanEEthShares can lead to executeTasks DOS
  • Loading branch information
jtfirek authored Nov 12, 2024
2 parents d0c7214 + 8386ed5 commit 7182d2b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/MembershipManager.sol
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ contract MembershipManager is Initializable, OwnableUpgradeable, PausableUpgrade
// Eth Rewards Amount per NFT = (eETH share amount of the NFT) * (total rewards ETH amount) / (total eETH share amount in ether.fan)
uint256 etherFanEEthShares = eETH.shares(address(this));
uint256 thresholdAmount = fanBoostThresholdEthAmount();
if (address(this).balance >= thresholdAmount) {
if (address(this).balance >= thresholdAmount && etherFanEEthShares > 0) {
uint256 mintedShare = liquidityPool.deposit{value: thresholdAmount}(address(this), address(0));
ethRewardsPerEEthShareAfterRebase += 1 ether * thresholdAmount / etherFanEEthShares;
}
Expand Down

0 comments on commit 7182d2b

Please sign in to comment.