-
Notifications
You must be signed in to change notification settings - Fork 36
Conversation
81a9ac2
to
75fb081
Compare
Have for now replaced the usage of |
|
||
async function bin() { | ||
const { stdout, stderr } = await execP('./bin/rlp encode "[ 5 ]"') | ||
exec('./bin/rlp encode "[ 5 ]"', (_error, stdout, _stderr) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, I was running into linting errors like 'error' is declared but its value is never read
here, however I didn't want to explicitly handle error and stuff here, so I googled towards the underscore solution. Is this a good way to do it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, I do this like this myself. Furthermore: _stderr
could be deleted entirely since it's the last parameter.
Yes we can! (but that woudln't work anyway because we will transpile language features not node API). But bascially we can create tsconfig (like Buuuut when I think about it we already did language transpilation since we target ES5 and tests failed due to different node API. We could change |
Ah, makes very much sense, for the moment maybe no need to do imminent changes in the setup. Thanks for approval! |
No description provided.