Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Add Address.equals(address: Address) #285

Merged
merged 1 commit into from
Jan 26, 2021
Merged

Add Address.equals(address: Address) #285

merged 1 commit into from
Jan 26, 2021

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Jan 21, 2021

This PR adds Address.equals(address: Address) along with tests to make comparison of Address objects easier.

Before:
address1.toBuffer().equals(address2.toBuffer())
After:
address1.equals(address2)

@coveralls
Copy link

coveralls commented Jan 21, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.003%) to 99.307% when pulling 93c43f7 on add-address-equals into dd2882d on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 99.307% when pulling 93c43f7 on add-address-equals into dd2882d on master.

@ryanio ryanio mentioned this pull request Jan 21, 2021
Merged
cgewecke
cgewecke approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@cgewecke cgewecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect 🙂

@ryanio
Copy link
Contributor Author

ryanio commented Jan 26, 2021

thanks!

@ryanio ryanio merged commit e19262e into master Jan 26, 2021
@ryanio ryanio deleted the add-address-equals branch January 26, 2021 03:16
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cgewecke cgewecke cgewecke approved these changes

Assignees
No one assigned
Labels
PR state: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanio @coveralls @cgewecke