Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Remove isPrecompiled method #242

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Remove isPrecompiled method #242

merged 1 commit into from
Apr 24, 2020

Conversation

cgewecke
Copy link
Contributor

@cgewecke cgewecke commented Apr 24, 2020 •
edited
Loading

Part of #172 Breaking API Changes

Per #172 comment:

This is a very error-prone and implicitly-HF-dependent method anyhow, which I have once removed from the VM and which currently has no other usages with EthereumJS. We should consider to remove.

PR removes:

  • method
  • tests
  • documentation

@holgerd77 holgerd77 mentioned this pull request Apr 24, 2020
Closed
@github-actions
Copy link

Coverage Status

Coverage decreased (-0.004%) to 99.642% when pulling cca171e on remove-is-precompile into 3bbc948 on master.

@github-actions
Copy link

Coverage Status

Coverage decreased (-0.004%) to 99.642% when pulling cca171e on remove-is-precompile into 3bbc948 on master.

@lgtm-com
Copy link

lgtm-com bot commented Apr 24, 2020

This pull request introduces 1 alert when merging cca171e into 3bbc948 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@cgewecke cgewecke mentioned this pull request Apr 24, 2020
Merged
@cgewecke cgewecke mentioned this pull request Apr 24, 2020
Merged
@cgewecke cgewecke requested a review from holgerd77 April 24, 2020 07:42
@holgerd77 holgerd77 mentioned this pull request Apr 24, 2020
Closed
holgerd77
holgerd77 approved these changes Apr 24, 2020
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

@holgerd77 holgerd77 merged commit 615d0c6 into master Apr 24, 2020
@holgerd77 holgerd77 deleted the remove-is-precompile branch April 24, 2020 15:35
@cgewecke cgewecke mentioned this pull request Apr 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cgewecke @holgerd77