Skip to content
This repository has been archived by the owner on Jun 17, 2021. It is now read-only.

Mv constants to own file #179

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Mv constants to own file #179

merged 1 commit into from
Feb 19, 2019

Conversation

s1na
Copy link
Contributor

@s1na s1na commented Feb 19, 2019

Follow up on #178. It moves constants to their own file (to prevent accidental changes), and re-exports them from index.ts. Tested by manually injecting into ethereumjs-account.

@holgerd77
Copy link
Member

Ah, we maybe have some more general coveralls problem - eventually some expired token or something? - will have a look.

@holgerd77
Copy link
Member

Ah, maybe do a switch to nyc on first run and see if this helps?

@s1na
Copy link
Contributor Author

s1na commented Feb 19, 2019

Seems like other people are experiencing the same issue (scroll down to the end)

@holgerd77
Copy link
Member

@s1na: Ok, will do admin-merges for now if that's the only task failing so that we can move forward till this is resolved.

@holgerd77
Copy link
Member

If it was a deliberate decision to use the singular constant version for the file naming I would be ok with it. I would find constants.js a bit more intuitive. But again: if this is following some own preference and/or naming convention I am not aware of this will also be ok.

Rename constant to constants
@s1na
Copy link
Contributor Author

s1na commented Feb 19, 2019

It was just out of habit :) I agree the plural is more intuitive usually, updated.

Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@holgerd77
Copy link
Member

Will do admin-merge due to current brokenness of the coveralls service.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants