Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rc.1 Releases #958

Merged
merged 8 commits into from
Nov 19, 2020
Merged

Rc.1 Releases #958

merged 8 commits into from
Nov 19, 2020

Conversation

holgerd77
Copy link
Member

Part of #907

First RC release series for the VM v5 and other monorepo libraries following #946

@codecov
Copy link

codecov bot commented Nov 18, 2020 •
edited
Loading

Codecov Report

Merging #958 (791d9f8) into master (fc3a70f) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

Flag Coverage Δ
block 77.69% <ø> (+0.27%) ⬆️
blockchain 77.39% <ø> (ø)
common 91.87% <ø> (ø)
ethash 82.08% <ø> (ø)
tx 86.04% <ø> (-0.22%) ⬇️
vm 87.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

jochem-brouwer
jochem-brouwer previously approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, great 😄

@ryanio
Copy link
Contributor

ryanio commented Nov 18, 2020

I just ran npm run docs:build and saw some files update so I can commit those to this PR.

ryanio
ryanio approved these changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@ryanio ryanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@holgerd77 holgerd77 merged commit c9c76bb into master Nov 19, 2020
@holgerd77 holgerd77 deleted the rc.1-releases branch November 19, 2020 09:27
@holgerd77
Copy link
Member Author

Ah, on another look, this would actually have been a good case to use the new type: test on all hardforks label. Won't make this prevent me doing the releases, but seems we all have to get used to considering this along PRs yet.

@holgerd77
Copy link
Member Author

Just published the following releases on npm 😄 :

@holgerd77 holgerd77 mentioned this pull request Nov 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanio ryanio ryanio approved these changes

@jochem-brouwer jochem-brouwer jochem-brouwer left review comments

@evertonfraga evertonfraga Awaiting requested review from evertonfraga

@rumkin rumkin Awaiting requested review from rumkin

Assignees
No one assigned
Labels
package: monorepo PR state: needs review type: release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holgerd77 @ryanio @jochem-brouwer