Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verkle: migrate to verkle-cryptography-wasm #3356

Merged
merged 11 commits into from
Apr 16, 2024

Conversation

gabrocheleau
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.50%. Comparing base (4be68d2) to head (adade3d).
Report is 6 commits behind head on master.

❗ Current head adade3d differs from pull request most recent head 899203d. Consider uploading reports for the commit 899203d to get more accurate results

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block ?
blockchain ?
client ?
common ?
devp2p ?
evm ?
genesis ?
statemanager ?
trie 59.62% <ø> (+0.02%) ⬆️
tx ?
util ?
vm 61.49% <ø> (-0.07%) ⬇️
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

@gabrocheleau gabrocheleau marked this pull request as ready for review April 15, 2024 18:52
acolytec3
acolytec3 previously approved these changes Apr 16, 2024
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acolytec3 acolytec3 merged commit 22746a1 into master Apr 16, 2024
34 checks passed
@holgerd77 holgerd77 deleted the verkle/verkle-crypto-wasm-migration branch April 16, 2024 13:25
/**
* An instantiated Verkle Cryptography interface
*/
verkleCrypto: any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to be typed as any?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants