common: configure kaustinen6 network #3355
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ation because of missing cache persist
| balanceAddress, | ||
| 0, | ||
| BALANCE_LEAF_KEY | ||
| ) | ||
|
|
||
| gas += coldAccessGas | ||
| charge2929Gas = coldAccessGas === BIGINT_0 |
There was a problem hiding this comment.
What is this check doing?
There was a problem hiding this comment.
2929 gas charges to be charged only if there is no "cold" access (so warm costs won't be charged even if warmed by accesslist)
There was a problem hiding this comment.
So should the check be coldAccessGas > BIGINT_0 just for clarity? I'm assuming coldAccessGas can never be negative.
There was a problem hiding this comment.
charge 2929 gas, when its not cold w.r.t. access charges (not cold = access charge is zero)
|
|
||
| let charge2929Gas = true | ||
| if (common.isActivatedEIP(6800)) { | ||
| // TODO: add check if toAddress is not a precompile |
There was a problem hiding this comment.
Should this TODO be resolved before we merge? Seems like a relatively simple check.
There was a problem hiding this comment.
need to do a precomiple check at lot many places, will do a followup PR for the same if thats ok
followup of
test and fix issues against the next iteration of verkle kaustinen5 as a stateless client
How to run:
/data/k6data) and start the client providing where to save payload of invalid blocks (/data/k6data/invalidblocks):npm run client:start:ts -- --ignoreStatelessInvalidExecs /data/k6data/invalidblocks --dataDir /data/k6data --network kaustinen6 --rpcEngine --rpcEngineAuth false --logLevel warnthe loglevel is kept warn so that only failures so unexpected warns/errors show up to reduce noise while syncing
k6data/lodestarand run the following:/setup.sh --dataDir k6data --network kaustinen6 --justCLto start lodestar