Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ethereum-cryptography from 1.2 to 2.0 #2639

Closed
wants to merge 4 commits into from
Closed

Update ethereum-cryptography from 1.2 to 2.0 #2639

wants to merge 4 commits into from

Conversation

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #2639 (3f9b315) into master (efc4487) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 3f9b315 differs from pull request most recent head 3da386b. Consider uploading reports for the commit 3da386b to get more accurate results

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 90.41% <ø> (+0.22%) ⬆️
blockchain 90.40% <ø> (ø)
client 87.12% <ø> (ø)
common 95.74% <ø> (ø)
devp2p 91.92% <100.00%> (+0.21%) ⬆️
ethash ∅ <ø> (∅)
evm 79.39% <ø> (ø)
rlp ∅ <ø> (?)
statemanager 89.61% <ø> (ø)
trie 90.36% <ø> (ø)
tx 94.38% <ø> (-0.05%) ⬇️
util 85.10% <100.00%> (-0.08%) ⬇️
vm 84.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member

Hi @paulmillr, thanks for this continued super-solid work providing a secure crypto part for our libraries! 🙏 ❤️ Can you do a last update here (we unluckily just merged a PR which touched the very same package.json parts), then I will approve and merge. We will do regular releases next week, this will get integrated there already. 🙂

@paulmillr
Copy link
Member Author

@holgerd77 done

@paulmillr
Copy link
Member Author

@holgerd77 wasn't able to rebase this in the current branch properly (git is complicated); but opened a new pull request

@paulmillr paulmillr closed this Apr 14, 2023
@paulmillr paulmillr deleted the ec2 branch April 30, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants