Editorial: Fix/ecip 1049 #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date: 2022-02-21 09:27:59-08:00 Signed-off-by: meows <[email protected]>
Date: 2022-02-21 09:33:16-08:00 Signed-off-by: meows <[email protected]>
|
LGTM |
gitr0n1n
previously requested changes
Feb 21, 2022
There was a problem hiding this comment.
For @bobsummerwill and his staff, I hope you find this helpful in bringing this ECIP into compliance with the ECIP process.
|
I do not see why you have blocked this PR, @gitr0n1n. These two changes from @meowsbits are free-standing and useful in their own right. |
IstoraMandiri
approved these changes
Feb 21, 2022
IstoraMandiri
dismissed
gitr0n1n’s stale review
Should not be blocked, these are minor fixes
The specification did not appear to be up to ECIP-1000 standards- but it certainly is better than none. The intent wasn't to "block" but request changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Licensefield in headerSpecificationsectionPer the bureaucratic regulations at
ECIP Format and Structure.