Add tuple decoder for events #1484
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Agree, will add it later when I've finished testing it with our dataset first. |
|
I'm surprised to see this PR abandoned as struct decoding is still broken in the latest version of the Any chance this PR can be pushed through so complex types can be properly decoded? eth_abi.exceptions.NoEntriesFound: No matching entries for 'tuple' in decoder registry |
cc7768
added a commit
to cc7768/web3.py
that referenced
this pull request
Nov 19, 2021
fselmo
pushed a commit
to cc7768/web3.py
that referenced
this pull request
Jan 12, 2022
fselmo
pushed a commit
to cc7768/web3.py
that referenced
this pull request
Jan 12, 2022
fselmo
pushed a commit
that referenced
this pull request
Jan 13, 2022
|
Closed by #2211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Struct in events can't be decoded.
How was it fixed?
Struct is mapped to tuple, and there's existing function to
convert it to decodable structure.
Todo:
Cute Animal Picture