Add python3.8 support #1471
Add python3.8 support #1471
Conversation
|
I expect the build to fail. cytoolz doesn't build against python3.8 yet. related issue |
|
Most of Ethereum's python tooling won't be able to update to |
|
A fix for cytoolz has been released. I have opened a PR in |
voith
force-pushed
the
python3.8
branch
4 times, most recently
from
30c5064 to
b8bbfdf
Compare
.circleci/config.yml
Outdated
| @@ -179,7 +179,8 @@ jobs: | |||
| - image: circleci/python:3.6 | |||
| environment: | |||
| TOXENV: py36-ethpm | |||
| WEB3_INFURA_PROJECT_ID: 4f1a358967c7474aae6f8f4a7698aefc | |||
| WEB3_INFURA_PROJECT_ID: ae13436d29b34850b640af9c80f80871 | |||
| WEB3_INFURA_API_SECRET: 067ddad6021048f0840a38a4e52eb568 | |||
There was a problem hiding this comment.
@kclowes @njgheorghita Tests were failing without WEB3_INFURA_API_SECRET . Here's a failing build. It seems to me that the handshake in websockets is much more strict in this new version(v8.1). I have generated this temporary key pair from my personal account. Please create a new key pair. The infura API is rate limited, so it'd be better to add these environment variables through circleci's config. Else the tests might fail randomly with rate limit errors if someone starts abusing this key.
There was a problem hiding this comment.
🤔 that's interesting. It seems like you shouldn't need the secret key unless something changed with that project. I wonder if the project settings associated with the key changed recently? It's not my key so I can't see it.
it'd be better to add these environment variables through circleci's config.
We opted to leave the keys in the code (usually with a comment that says please don't abuse) because anyone who contributes has access to the circle env variables anyway and we thought it's better to just put them out there, rather than have someone assume at some point that the CircleCI env vars are actually secret and expose a real vulnerability. If someone abuses we'll just change them out.
There was a problem hiding this comment.
Tests were failing without WEB3_INFURA_API_SECRET .
It seems like you shouldn't need the secret key unless something changed with that project.
Yup, nothing's changed with the project settings, so I'm not sure that this was the cause of the error, as it looks like we're not close to hitting the rate limits on that key. For the 4f1.... key's project settings, you don't need a secret. I'm guessing it was just a glitchy request with Infura. I just ran the tests with the 4f1... key and everything seemed to pass just fine.
There was a problem hiding this comment.
well, I couldn't replicate the error locally on OSX. However, after entering circleCI in debug mode, the secret key is the only thing that fixed the issue. I was getting a 401 unauthorized error.
Here's a similar issue in websockets.
There was a problem hiding this comment.
I couldn't get circle tests to pass without the secret key either ¯_(ツ)_/¯. Updated to a throw-away key.
| py38-integration-parity-ipc: | ||
| <<: *parity_steps | ||
| docker: | ||
| - image: circleci/python:3.8 |
There was a problem hiding this comment.
I want to point out that it seems like stretch images are no longer needed. Back when this commit was added parity would fail to build on other distros.
|
argh, looks like the checksum of parity binary has changed. I can take a look at this tomorrow. |
updated import path for TimeoutError
Tests are green now. The test failures were random and had nothing to do with the change in the checksum. |
What was wrong?
web3.py doesn't support python3.8.
How was it fixed?
Add support for python 3.8.
Todo:
Cute Animal Picture