Implement eth_chainId endpoint #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
force-pushed
the
eth_chainId
branch
5 times, most recently
from
2ec2a58
to
5560e7e
Compare
|
You should be able to use ethereum/go-ethereum#17617 to backtrack which version is needed. Would be nice to update the geth integration version to test out eth_chainId |
njgheorghita
force-pushed
the
eth_chainId
branch
5 times, most recently
from
da84c39
to
c9d9908
Compare
njgheorghita
force-pushed
the
eth_chainId
branch
from
c9d9908
to
d6833a9
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Implement
eth_chainIdre: @carver 's comment here & on Gitter.Though, it appears it's not implemented in Geth yet? Or just not in the versions we're testing against. Also, Parity simply returns a
null, which according to this means that it's unavailable.Cute Animal Picture