changed ValueError -> ValidationError and updated corresponding test

ethereum · Apr 10, 2018 · 6228420 · 6228420
1 parent 89d8503
commit 6228420
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/tests/core/eth-module/test_poa.py b/tests/core/eth-module/test_poa.py
@@ -1,5 +1,8 @@
 import pytest
 
+from web3.exceptions import (
+    ValidationError,
+)
 from web3.middleware import (
     construct_fixture_middleware,
     geth_poa_middleware,
@@ -12,7 +15,7 @@ def test_long_extra_data(web3):
         'eth_getBlockByNumber': {'extraData': '0x' + 'ff' * 33},
     })
     web3.middleware_stack.inject(return_block_with_long_extra_data, layer=0)
-    with pytest.raises(ValueError):
+    with pytest.raises(ValidationError):
         web3.eth.getBlock('latest')
 
 

diff --git a/web3/middleware/pythonic.py b/web3/middleware/pythonic.py
@@ -28,6 +28,9 @@
     HexBytes,
 )
 
+from web3.exceptions import (
+    ValidationError,
+)
 from web3.utils.encoding import (
     hexstr_if_str,
     to_hex,
@@ -70,7 +73,7 @@ def check_extradata_length(val, length):
         return val
     result = HexBytes(val)
     if len(result) > length:
-        raise ValueError(
+        raise ValidationError(
             "The field extraData: %r is %d bytes, but should be %d. "
             "It is quite likely that you are connected to a POA chain. "
             "Refer "