This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Add a maximum batch size for regular sync imports #704
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this maximum batch size, when the first batch takes a long time
to execute, the second batch will be enormous. Perhaps most importantly,
the back-pressure set by
_db_buffer_capacity
is never triggered if thebatch is unlimited size. So the header downloader races ahead unimpeded.
I think this was something that @veox noticed.
Note that beam sync uses the regular syncer updated in this PR, which is why it was originally bundled in #641 .
To-Do
Cute Animal Picture