This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Fix #437, add slot ticker #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipermerriam
reviewed
Apr 9, 2019
ChihChengLiang
force-pushed
the
slot-ticker-and-validator-service
branch
from
1a20705 to
7e6e78d
Compare
7 tasks
mhchia
approved these changes
Apr 16, 2019
|
|
||
|
|
||
| class SlotTicker(BaseService): | ||
|
|
There was a problem hiding this comment.
nits: should the fields be declared with type ahead of the methods?
NIC619
approved these changes
Apr 16, 2019
|
Merge to unblock other tasks, post PR feedbacks are welcomed. 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
#437 Add a slot ticker for the validator
How was it fixed?
Cute Animal Picture