This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
Implement process_deposits
#447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2019
hwwhww
force-pushed
the
process_deposits
branch
from
c2ca4bd to
10d0d97
Compare
ChihChengLiang
approved these changes
Mar 28, 2019
eth2/_utils/merkle/sparse.py
Outdated
| @@ -5,7 +5,7 @@ | |||
| not considered to be part of the tree. | |||
| """ | |||
|
|
|||
| from typing import ( | |||
| from typing import ( # noqa: F401 | |||
| @@ -53,6 +52,7 @@ | |||
| from eth2.beacon.types.attester_slashings import AttesterSlashing # noqa: F401 | |||
| from eth2.beacon.types.blocks import BaseBeaconBlock # noqa: F401 | |||
| from eth2.beacon.types.crosslink_records import CrosslinkRecord | |||
| from eth2.beacon.types.deposits import Deposit # noqa: F401 | |||
There was a problem hiding this comment.
These diffs look weird, Deposit is never used here. And Also these imports should not have noqa here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #238
How was it fixed?
process_deposit- generalize it to be used in processing genesis and deposit operation.process_depositsgenesis_eth1_datainget_genesis_beacon_stateDeposit.branch->Deposit.prooftrinity/config.py- usecreate_mock_genesisfor chain initializationCute Animal Picture