Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Fork version: bytes4 #426

Merged
merged 2 commits into from
Mar 19, 2019
Merged

Fork version: bytes4 #426

merged 2 commits into from
Mar 19, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Mar 17, 2019

What was wrong?

Fix #416

How was it fixed?

  1. Update Fork, get_fork_version, get_domain as the spec PR.
  2. Fix test_validate_proposer_signature: should have used get_domain.

Cute Animal Picture

animal-1842152_640

@hwwhww hwwhww added the eth2.0 label Mar 17, 2019
@hwwhww hwwhww requested a review from NIC619 March 17, 2019 07:08
NIC619
NIC619 approved these changes Mar 18, 2019
View reviewed changes
Copy link
Contributor

@NIC619 NIC619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hwwhww hwwhww merged commit 1936528 into ethereum:master Mar 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NIC619 NIC619 NIC619 approved these changes

Assignees
No one assigned
Labels
eth2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve fork version/signature domain semantics
2 participants
@hwwhww @NIC619