Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Update AttesationData: latest_crosslink_root: Hash32 to latest_crosslink: CrosslinkRecord #351

Merged
merged 2 commits into from
Mar 2, 2019

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Mar 2, 2019

What was wrong?

#343 task 4: Update AttesationData: latest_crosslink_root: Hash32 to latest_crosslink: CrosslinkRecord

How was it fixed?

  1. Rename AttesationData.latest_crosslink_root to AttesationData.latest_crosslink.
  2. Change the type to CrosslinkRecord and fix the related logic.
  3. Remove the outdated SlashableAttestation.hash tests

Cute Animal Picture

hedgehog-child-1759027_640

`AttestationData.latest_crosslink` and also change the type
@hwwhww hwwhww requested a review from NIC619 March 2, 2019 17:33
@hwwhww hwwhww added the eth2.0 label Mar 2, 2019
Copy link
Contributor

@NIC619 NIC619 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hwwhww hwwhww merged commit 87a133f into ethereum:master Mar 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants