Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

Spec sync #324

Merged
merged 10 commits into from
Feb 27, 2019
Merged

Spec sync #324

merged 10 commits into from
Feb 27, 2019

Conversation

ralexstokes
Copy link
Member

What was wrong?

I was looking at exactly what functionality remained to reach our first pass at a full state transition function for the beacon chain.

How was it fixed?

The existing code was compared to the current spec. There was some refactoring done to make parts of the state transition more manageable.

Cute Animal Picture

put a cute animal picture link inside the parentheses

@ralexstokes ralexstokes changed the title Spec sync [WIP] Spec sync Feb 27, 2019
@ralexstokes
Copy link
Member Author

need to fix linter

@ralexstokes
Copy link
Member Author

@hwwhww heads up if this is merged, there may be a merge conflict w/ #314.

@ralexstokes
Copy link
Member Author

ralexstokes commented Feb 27, 2019

pending spec changes, here is the missing functionality required to complete the beacon chain state transition function:

edit: add cute lil checkboxes to indicate they are in flight to being merged

Copy link
Contributor

@hwwhww hwwhww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks good to me 👍
Another nitpick: rename local variable num_shards_in_committees to current_epoch_committee_count to match the spec.

Defer to @pipermerriam on the inner function usage.

@ralexstokes ralexstokes merged commit b08a481 into ethereum:master Feb 27, 2019
@ralexstokes ralexstokes deleted the spec-sync branch February 27, 2019 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants