This repository has been archived by the owner on Jul 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to fix linter |
This was referenced Feb 27, 2019
ralexstokes
commented
Feb 27, 2019
pending spec changes, here is the missing functionality required to complete the beacon chain state transition function:
edit: add cute lil checkboxes to indicate they are in flight to being merged |
hwwhww
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic looks good to me 👍
Another nitpick: rename local variable num_shards_in_committees
to current_epoch_committee_count
to match the spec.
Defer to @pipermerriam on the inner
function usage.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
I was looking at exactly what functionality remained to reach our first pass at a full state transition function for the beacon chain.
How was it fixed?
The existing code was compared to the current spec. There was some refactoring done to make parts of the state transition more manageable.
Cute Animal Picture