feat(state-bridge): add support for gossiping blocks from a range #1497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KolbyML
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
State Bridge only supports gossiping blocks starting from 0.
We know that content from first ~500'000 blocks are saturated, and we might want to skip them to speed up the process.
How was it fixed?
Add support for range gossip.
We will still execute blocks starting from zero, but we will gossip only blocks from the range.
Specifying single block would imply gossiping all blocks starting from zero and ending with provided block.
This was left unmodified for backward compatibility, until we upgrade deployment scripts.
In my opinion, single block should gossip entire state trie at the specified block (but this requires more work).
To-Do