Add peer failures to query traces #1479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carver
commented
Sep 23, 2024
| @@ -21,6 +21,8 @@ pub struct QueryTrace { | |||
| pub origin: NodeId, | |||
| /// Map of a node's ID to its corresponding `QueryResponse` | |||
| pub responses: HashMap<NodeId, QueryResponse>, | |||
| /// Track if and how each node fails during a query | |||
| pub failures: HashMap<NodeId, QueryFailure>, | |||
There was a problem hiding this comment.
@mrferris what do you think about this structure, for tracking failures types and times, for each peer?
(PR is unfinished, I just remember you saying you had opinions on this data structure, and figured I'd get early feedback)
Recognized failure types include: - utp connection failure - utp transfer failure - content validation failure
When querying content, the trace will now record if the content validation fails or of the utp download fails. It currently does not tell the difference between a utp connection error and a download error.
carver
force-pushed
the
trace-failed-content
branch
from
4106a12
to
ca72d09
Compare
mrferris
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
There is no way to acknowledge and track whether a peer experiences a variety of failures during a query, and how long that took.
How was it fixed?
Add a new tracking HashMap in the QueryTrace object, to track utp and validation errors.
Still need to actually use the new QueryTrace API in the overlay service.
To-Do