Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update dockerfile rustc version #1468

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: update dockerfile rustc version #1468

merged 1 commit into from
Sep 19, 2024

Conversation

njgheorghita
Copy link
Collaborator

@njgheorghita njgheorghita commented Sep 19, 2024 •
edited
Loading

What was wrong?

rustc version chosen in dockerfiles needed updating to reflect changes in #1466

How was it fixed?

To-Do

@njgheorghita njgheorghita marked this pull request as ready for review September 19, 2024 21:42
KolbyML
KolbyML approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@KolbyML KolbyML self-requested a review September 19, 2024 21:43
KolbyML
KolbyML requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the rest of our stuff to the new rust version no?

@KolbyML
Copy link
Member

KolbyML commented Sep 19, 2024

Like this PR did for 1.80.0 #1421

@KolbyML KolbyML self-requested a review September 19, 2024 21:44
@njgheorghita njgheorghita force-pushed the dockerfile-rust-version branch 2 times, most recently from 689239c to bff38b0 Compare September 19, 2024 21:51
KolbyML
KolbyML approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: PR looks good

on merging it would be cool if the commit message was more descriptive now that the scope of the PR changed, but either way not a big issue so no worries

@njgheorghita njgheorghita merged commit 85d8b45 into ethereum:master Sep 19, 2024
12 checks passed
@njgheorghita njgheorghita deleted the dockerfile-rust-version branch September 19, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KolbyML KolbyML KolbyML approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@njgheorghita @KolbyML