Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credit first peer to return content #1447

Merged
merged 7 commits into from
Sep 13, 2024
Merged

Credit first peer to return content #1447

merged 7 commits into from
Sep 13, 2024

Commits on Sep 13, 2024

  1. perf: remove a wasteful content.clone()

    @carver
    carver committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    78a2c29 View commit details
    Browse the repository at this point in the history

  2. chore: make TNodeId loggable in FindContentQuery

    @carver
    carver committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    2d367bb View commit details
    Browse the repository at this point in the history

  3. test: termination_and_parallelism logging 

    Find Content tests were challenging to debug.

Add more logged info when the test fails, and showing important
milestones of the test cycle.

Additionally, refactor the naming of `remaining` and `expected` a bit to
make reading the test more welcoming to newcomers.
    @carver
    carver committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    851cf2e View commit details
    Browse the repository at this point in the history

  4. test: find content should credit the earliest peer 

    When multiple peers return the content, the result should give
credit to the first peer that responds, not the last.

Also, this bug was not found locally because 10 iterations wasn't enough
to expose the issue the first time. Increasing to 100, which still takes
only 200ms, and was reliably reproducing this issue.
    @carver
    carver committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    c6da0d2 View commit details
    Browse the repository at this point in the history

  5. chore(light-client): clippy fix: unwrap_or_default

    @carver
    carver committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    5effda0 View commit details
    Browse the repository at this point in the history

  6. test: show filename of missing file, if test fails 

    In ethportal-peertest, it showed that a file was missing, but not which
one. That information is critical, and self_peertest runs slowly, so
reducing reruns is very valuable.
    @carver
    carver committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    0fb6e2d View commit details
    Browse the repository at this point in the history

  7. chore: a clearer comment and match pattern 

    When checking for a local copy of content requested by a peer, the
comment explaining the case for missing content should match the order
of the pattern. Also, the pattern itself is made a little clearer.
    @carver
    carver committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    65ef35e View commit details
    Browse the repository at this point in the history