Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(beacon): improve LightClientBootstrap validation #1433

Merged
merged 2 commits into from
Sep 11, 2024
Merged

feat(beacon): improve LightClientBootstrap validation #1433

merged 2 commits into from
Sep 11, 2024

Conversation

ogenev
Copy link
Member

@ogenev ogenev commented Sep 10, 2024

What was wrong?

Fixes part 1 of #1406.

How was it fixed?

  • Add JSON-RPC endpoint to get the recently finalized beacon block header
  • Compare the LightClientBootstrap header with the recently finalized beacon block header before gossiping and storing the content.

To-Do

@ogenev ogenev added the beacon network Issue related to portal beacon network label Sep 10, 2024
@ogenev ogenev self-assigned this Sep 10, 2024
@ogenev ogenev marked this pull request as ready for review September 10, 2024 16:04
KolbyML
KolbyML approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ogenev ogenev merged commit 59ebc5a into ethereum:master Sep 11, 2024
9 checks passed
@ogenev ogenev deleted the bootstrap-validation branch September 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KolbyML KolbyML KolbyML approved these changes

@njgheorghita njgheorghita Awaiting requested review from njgheorghita

@carver carver Awaiting requested review from carver

Assignees

@ogenev ogenev

Labels
beacon network Issue related to portal beacon network
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ogenev @KolbyML