Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ssz feature back for alloy-primitives to fix test compiling #1411

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

KolbyML
Copy link
Member

@KolbyML KolbyML commented Sep 2, 2024

What was wrong?

the tests I am trying to run locally are all failing, because we removed the ssz feature from alloy-primitives in the PR updating Cargo to properly use workplace

so I got thousands of error's stating can't derive ssz for B256, ... 5 billion other errors etc. I was running tests in block_body.rs

depends

How was it fixed?

by adding the feature back which was removed

Copy link
Collaborator

@morph-dev morph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would even consider enabling this feature in the [workspace.dependencies] in root Cargo.toml.

Copy link
Collaborator

@morph-dev morph-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now you can remove it from trin-validation/Cargo.toml

@KolbyML KolbyML merged commit 16e5aee into ethereum:master Sep 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants