Switch Cargo.toml in packages to use workspace dependencies #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I checked that all of these dependencies are used in other repos first.
It's much nicer to have the dependency versions defined once in the repo, for future upgrades. Why did the version spec change when moving to the root Cargo.toml? - hyper is used elswehere with different features, like rpc - serde is used elsewhere at higher versions, like portalnet - serde_yaml is used elsewhere at higher versions, like in trin-beacon
Why did the version spec change when moving to the root Cargo.toml? - async-trait is used elsewhere at higher versions, like portal-bridge - chrono is used elsewhere at higher versions, like trin-beacon
carver
force-pushed
the
workspace-dependencies
branch
from
e66c2d6
to
72f7e67
Compare
looks good
morph-dev
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Looks good! 🚢
Few sidenotes.
Since Cargo.lock wasn't updated, does that mean that there was no dependency that was used with different version?
Somewhat related, should we create issue(s) for:
- figuring out if we have some unused dependencies that can be removed
- e.g. using some tools like cargo-udeps
- if we find convenient tool, maybe create a github action that runs it weekly (similar to update dependencies)
- finding out if we have multiple crates that do the same thing and we can simplify to using one (e.g. I noticed
ssz-rsinlight-clientand I'm wondering if we can replace it withethereum_ssz)- probably more of a manual task, but it might not be too hard not that most dependencies are in one place
Yeah, I think because of the regular updates, like this one, most of the locked dependencies were further ahead of any of the Cargo.toml specs anyway.
Sure, I'll take a stab at writing some up 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fix #845
How was it fixed?
My process:
There are several dependencies that are only used in a single package. I can see arguments for moving them to the workspace for tracking too. For example, if we don't move the dependencies, then it will be easy to accidentally create duplicates again in the future. But I landed on leaving them in place, because:
But I'm open to persuasive arguments :)
To-Do