feat: add jsonrpc endpoint for offer with trace #1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njgheorghita
commented
Aug 21, 2024
| enr: Enr, | ||
| content_key: BeaconContentKey, | ||
| content_value: BeaconContentValue, | ||
| ) -> RpcResult<bool>; |
There was a problem hiding this comment.
It's possible that in the future it might be useful to know whether or not the false case is because the Accept was declined or the utp transfer failed, but for the time being a simple bool is already useful in the new bridge, and we can update the response type later if a more granular response is warranted.
njgheorghita
force-pushed
the
trace-offer
branch
from
5272b7d
to
9e9c6ed
Compare
njgheorghita
force-pushed
the
trace-offer
branch
from
9e9c6ed
to
4312855
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The simple
Offerjsonrpc endpoint doesn't return the result of the content transmission, just the initialAcceptmessage. In the updated bridge, waiting for the actual result of this utp transmission is very useful.How was it fixed?
Exposed jsonrpc access to
PopulatedRequestWithResultrequest type.To-Do