-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more metrics to trin execution #1355
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for splitting it up.
@@ -3,7 +3,7 @@ apiVersion: 1 | |||
datasources: | |||
- name: Prometheus | |||
type: prometheus | |||
url: http://prometheus:9090 | |||
url: http://localhost:9090 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this doesn't look right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I need to add another separate datasource to support both macos and linux, but what I do know, is http://prometheus:9090 doesn't work on linux
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think because of my updates to docker-compose this should work. I don't run this on macos anymore, so if someone finds a bug we can fix it then
- targets: ["host.docker.internal:9091"] | ||
- targets: | ||
- host.docker.internal:9091 | ||
- localhost:9091 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure about this one either (but it might be ok, since it has both)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so both MacOS works and Linux
Milos said I should try to take what I can from my big PR so I will do that, I will need a week to split .era2 PR more, but I will pull out anything that can be reviewed which can't break my database code for now
What was wrong?
There wasn't enough metrics to understand things like transaction progress times, storage etc
How was it fixed?
By updating