-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Difficulty Tests for ArrowGlacier #972
Conversation
please. lets do one at a time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plese lets divide and conquer
bba5195
to
ae52f31
Compare
This PR now only contains ArrowGlacier difficulty tests. |
{ | ||
"difficultyArrowGlacierFromLondon": { | ||
"_info": { | ||
"comment": "London->ArrowGlacier gradual difficulty increase test: blocks 13460000 - 15000000, step 5000 blocks, uncle rate 5% " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this test originate from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I filled these test cases externally with a python script, I did not want the filler to make an exhaustive combination so I took a mainnet block as input and start point, and the script filled the steps of the test case where the difficulty gradually increases, to try to simulate the difficulty increase feedback loop in normal block production.
If this is not ok, I think another approach could be to add a filler with combinations on the block where block is supposed to happen.
{ | ||
"difficultyArrowGlacierFromLondonAggressive": { | ||
"_info": { | ||
"comment": "London->ArrowGlacier aggressive difficulty increase test: blocks 13460000 - 15000000, step 5000 blocks, uncle rate 15%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
source of the test?
ae52f31
to
04e1468
Compare
This PR contains updated tests from BasicTests to the new DifficultyTests category format.Updated tests include: difficultyByzantium, difficultyConstantinople, difficultyFrontier, difficultyHomestead, difficultyEIP2384, difficultyEIP2384_random, difficultyEIP2384_random_to20M.Currently, difficultyEIP2384_random and difficultyEIP2384_random_to20M fail due to ethereum/go-ethereum#23818.Update: This PR now only contains ArrowGlacier tests.
New ArrowGlacier tests include:
All ArrowGlacier test cases are completing without issues.