-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests according to Mega-EOF spec #1238
Conversation
has all of this been postphoned to Prague ? |
Yes it was. |
BlockChain test jsons are mostly not updated yet? |
f6265ec
to
e53f5f5
Compare
All State Tests and blockchain tests has been filled with evmone. |
src/EIPTestsFiller/StateTests/stEOF/stEIP5450/EOF1_CALLF_ExecutionFiller.yml
Show resolved
Hide resolved
src/EIPTestsFiller/StateTests/stEOF/stEIP5450/EOF1_CALLF_ExecutionFiller.yml
Show resolved
Hide resolved
Rebased without refilling |
Tried refilling but seems the rebase didn't affect the fillers in this PR, json files were not modified. |
@winsvega This is ready to go, please review |
# deployed code: | ||
# code section: PUSH1(0) POP STOP | ||
# data section: aabbccdd | ||
- ':label eof1_initcode_deploying_valid_eof1_with_data :raw 0xef0001010004020001002903000000000000027fef00010100040200010004030004000000000160005000aabbccdd0000000000600052601b6000f3' | ||
- ':label eof1_initcode_deploying_valid_eof1_with_data :yul-eof { mstore(0, 0xef00010100040200010004040004000000000160005000aabbccdd0000000000) return(0, 27) }' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is now an argument support you can pass to the script like if you have custom solc version build with prague support (solc has --evm-version flag)
so you can use it here without custom .sh as :yul prague {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the heads up, Does this new feature still requires having a yul-eof.sh
script or it is no longer needed?
Currently, as these changes in spec are recent, I'm using a yul-eof.sh
script that converts the yul code to EVM and then to EOF.
@@ -217,16 +217,16 @@ for (i=0; i<10; i++) push10 += "30" | |||
|
|||
push100 = "" // Push a hundred values into the stack | |||
// assume push10 is code segment 1 | |||
for(var i=0; i<10; i++) push100 += "B00001" | |||
for(var i=0; i<10; i++) push100 += "E30001" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use .py test fillers for combinatorics tests in the future
please rebase on develop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the PR, and it looks good. If retesteth
fills the tests and they run correctly, I think this should be merged.
Rebased |
03
->04
)