Support the updated EIP2333 (BLS v4) #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 18, 2020
|
Hey @CarlBeek :) We have this in a PR as well (sigp/lighthouse#1633) and we're wondering if we should be aiming to have this change implemented for Spadina? |
|
@paulhauner @mratsim I would like to merge this for Spadina. The reason being is that I want as few versions of the old key derivation mechanism out there as possible in the event that people fail to update any key-generation version. In a future improvement to this CLI, I will integrate version checking to make sure that the wrong keys aren't uploaded to the Launchpad, but this doesn't help with keys generated using other sources (eg. clients themselves). |
bors bot
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Sep 23, 2020
## Issue Addressed #1624 ## Proposed Changes Updates to match [EIP-2333](`https://eips.ethereum.org/EIPS/eip-2333`) ## Additional Info In order to have compatibility with the eth2.0-deposit-cli, [this PR](ethereum/staking-deposit-cli#108) must also be merged
This was referenced Sep 24, 2020
paulhauner
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Sep 26, 2020
## Issue Addressed #1624 ## Proposed Changes Updates to match [EIP-2333](`https://eips.ethereum.org/EIPS/eip-2333`) ## Additional Info In order to have compatibility with the eth2.0-deposit-cli, [this PR](ethereum/staking-deposit-cli#108) must also be merged
paulhauner
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Sep 26, 2020
## Issue Addressed #1624 ## Proposed Changes Updates to match [EIP-2333](`https://eips.ethereum.org/EIPS/eip-2333`) ## Additional Info In order to have compatibility with the eth2.0-deposit-cli, [this PR](ethereum/staking-deposit-cli#108) must also be merged
paulhauner
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Sep 27, 2020
## Issue Addressed #1624 ## Proposed Changes Updates to match [EIP-2333](`https://eips.ethereum.org/EIPS/eip-2333`) ## Additional Info In order to have compatibility with the eth2.0-deposit-cli, [this PR](ethereum/staking-deposit-cli#108) must also be merged
paulhauner
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Sep 28, 2020
## Issue Addressed #1624 ## Proposed Changes Updates to match [EIP-2333](`https://eips.ethereum.org/EIPS/eip-2333`) ## Additional Info In order to have compatibility with the eth2.0-deposit-cli, [this PR](ethereum/staking-deposit-cli#108) must also be merged
paulhauner
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Sep 29, 2020
## Issue Addressed #1624 ## Proposed Changes Updates to match [EIP-2333](`https://eips.ethereum.org/EIPS/eip-2333`) ## Additional Info In order to have compatibility with the eth2.0-deposit-cli, [this PR](ethereum/staking-deposit-cli#108) must also be merged
paulhauner
pushed a commit
to sigp/lighthouse
that referenced
this pull request
Oct 1, 2020
## Issue Addressed #1624 ## Proposed Changes Updates to match [EIP-2333](`https://eips.ethereum.org/EIPS/eip-2333`) ## Additional Info In order to have compatibility with the eth2.0-deposit-cli, [this PR](ethereum/staking-deposit-cli#108) must also be merged
everhusk
pushed a commit
to earthwallet/earth-wallet-cli
that referenced
this pull request
Aug 3, 2023
Support the updated EIP2333 (BLS v4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BLS specifications were updated to v3 (which was backwards compatible with v3 for this EIP) and then BLS v4 which has breaking backwards compatibility of the function hkdf_mod_r. This PR updates EIP2333 to preserve the invariant that the BLS specs' KeyGen implements hkdf_mod_r.
The changes to the EIP can be seen Here: https://github.com/ethereum/EIPs/pull/2985/files