Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle solc links in repo when fetching compiler #979

Merged
merged 3 commits into from
Apr 14, 2023

Conversation

marcocastignoli
Copy link
Member

@marcocastignoli marcocastignoli commented Apr 14, 2023

See #975 for details

View in Huly HI-704

@marcocastignoli
Copy link
Member Author

In this way I'm saving the file in the repo with the "wrong name", but I think it makes sense. Because that's the solc name specified in the metadata.

E.g.

  1. sourcify asks for soljson-v0.5.14+commit.1f1aaa4.js
  2. soljson-v0.5.14+commit.1f1aaa4.js is actually a link to soljson-v0.5.14+commit.01f1aaa4.js
  3. fetch soljson-v0.5.14+commit.01f1aaa4.js but save it as soljson-v0.5.14+commit.1f1aaa4.js
  4. next time soljson-v0.5.14+commit.1f1aaa4.js is requested, the file is read locally

A potential enhancement would be to store also soljson-v0.5.14+commit.01f1aaa4.js as a link to soljson-v0.5.14+commit.1f1aaa4.js

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -2.24 ⚠️

Comparison is base (9f73842) 77.58% compared to head (ca07fa3) 75.34%.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging     #979      +/-   ##
===========================================
- Coverage    77.58%   75.34%   -2.24%     
===========================================
  Files           29       36       +7     
  Lines         1374     2008     +634     
  Branches       254      392     +138     
===========================================
+ Hits          1066     1513     +447     
- Misses         180      288     +108     
- Partials       128      207      +79     
Flag Coverage Δ
lib-sourcify 69.71% <ø> (?)
server 77.94% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuzdogan kuzdogan merged commit fc21cba into staging Apr 14, 2023
@kuzdogan kuzdogan deleted the handle-solc-links-in-repo branch May 10, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants