-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify with immutableReferences
#973
Conversation
Since using `immutableReferences`, the contracts that coudl only be verified with "simulation" can already be verified with "matchWithDeployedBytecode". This renders the prev. "simulation" tests useless. Modify those tests for the new case accordingly, remove irrelevant tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After looking at this, I think that the only case in which other verification methods are useful is when the compiler can't generate the ImmutableReferences object, but can it happen?
I'm in favor for keeping this as the only verification method.
I don't think that would ever happen. That'd be a compiler bug. Ok, good. Still we should not remove it immediately but after making sure we won't need them |
Uses the
immutableReferences
output of the compiler to set the immutable values in the onchain bytecode to0000...
before matching. Saves them in a file calledimmutable-references.json
.Fix #972
lib-sourcify
toolib-sourcify
tests.creatorTxHash
tests but adds them as unit tests below.replaceImmutableReferences
function.View in Huly HI-709