Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test coverage #963

Merged
merged 13 commits into from
Mar 14, 2023
Merged

Test coverage #963

merged 13 commits into from
Mar 14, 2023

Conversation

marcocastignoli
Copy link
Member

@marcocastignoli marcocastignoli commented Mar 13, 2023 •
edited by kuzdogan
Loading

  • now tests run with nyc
  • enable coverage export with lcov
  • push coverage to +75% for lib-sourcify and server
  • branch coverage is not covered yet
  • automatically generate coverage badge triggering codecov after tests are successful

View in Huly HI-711

@marcocastignoli marcocastignoli linked an issue Mar 13, 2023 that may be closed by this pull request
Add Coverage Reports #937
Closed
kuzdogan
kuzdogan reviewed Mar 14, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
packages/lib-sourcify/README.md Show resolved Hide resolved
src/server/services/RepositoryService.ts Show resolved Hide resolved
packages/lib-sourcify/test/validation.spec.ts Outdated Show resolved Hide resolved
packages/lib-sourcify/test/validation.spec.ts Show resolved Hide resolved
packages/lib-sourcify/test/functions.spec.ts Show resolved Hide resolved
packages/lib-sourcify/test/functions.spec.ts Outdated Show resolved Hide resolved
packages/contract-call-decoder/package.json Show resolved Hide resolved
kuzdogan
kuzdogan requested changes Mar 14, 2023
View reviewed changes
Copy link
Member

@kuzdogan kuzdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the comments.

I think unit tests in general need checking the results. Otherwise small changes

@kuzdogan kuzdogan merged commit 1dd0040 into staging Mar 14, 2023
@kuzdogan kuzdogan deleted the test-coverage branch May 10, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuzdogan kuzdogan kuzdogan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Coverage Reports
2 participants
@marcocastignoli @kuzdogan