User input creator tx #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep the exact content of the JSON file consistent, it is better to stringify the JSON without adding tabs and spaces, just as we do with the metadata.json
Different store methods for metadata, library-map etc. was redundant. Essentially there are: - sources - JSON files - Txt files The number of functions can be reduced without losing readability easily.
Lets passing the creatorTxHash variable in the API. Saves the creatorTxHash inside "creator-tx-hash.txt" file in the contract folder. Adds the server tests for verifying a withImmutable contract.
marcocastignoli
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes enable passing the
creatorTxHashvariable to server. Normally this is scraped from an explorer or fetched with an API but sometimes this fails. This allows users to provide it themselves.TODO:
View in Huly HI-734