Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dockerized ipfs nodes unreachable #520

Merged
merged 1 commit into from
Sep 7, 2021
Merged

Fix dockerized ipfs nodes unreachable #520

merged 1 commit into from
Sep 7, 2021

Conversation

kuzdogan
Copy link
Member

@kuzdogan kuzdogan commented Sep 7, 2021

The previous server profile disables localhost discovery. According to docs this is for when running a server but breaks things when dockerized. Change should make the ipfs node reachable over the docker network and also from outside.

See #495

View in Huly HI-1013

The previous `server` profile disables localhost discovery. According to [docs](https://github.com/ipfs/go-ipfs/blob/master/docs/config.md#profiles) this is for when running a server but breaks things when dockerized. Change should make the ipfs node reachable over the docker network and also from outside.

See #495
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ogwurujohnson ogwurujohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@chriseth chriseth merged commit 0482235 into ethereum:staging Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants