Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update contract_deployments table after storing a match that previously didn't have contract creation information #1408

Merged
merged 6 commits into from
Jun 4, 2024
Merged

Update contract_deployments table after storing a match that previously didn't have contract creation information #1408

merged 6 commits into from
Jun 4, 2024

Conversation

marcocastignoli
Copy link
Member

@marcocastignoli marcocastignoli commented May 28, 2024 •
edited
Loading

@marcocastignoli marcocastignoli linked an issue May 28, 2024 that may be closed by this pull request
Update contract_deployments after storing a better match with creatorTx information #1405
Closed
@marcocastignoli
When updating onchain data for better creation information:
0c50b49 
- always insert a new row in `contracts`
- update `contract_deployments` with the new contrats id
@marcocastignoli marcocastignoli mentioned this pull request May 31, 2024
Merged
@marcocastignoli marcocastignoli marked this pull request as ready for review June 3, 2024 13:33
manuelwedler
manuelwedler reviewed Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@manuelwedler manuelwedler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have this fixed :) I just have some minor comments, looks good other than that

services/server/test/integration/verification-handlers/verify.stateless.spec.ts Outdated Show resolved Hide resolved
services/server/src/server/services/utils/database-util.ts Outdated Show resolved Hide resolved
services/server/src/server/services/utils/database-util.ts Show resolved Hide resolved
@marcocastignoli marcocastignoli merged commit c3c7deb into staging Jun 4, 2024
6 checks passed
This was referenced Jun 6, 2024
Closed
Closed
@kuzdogan kuzdogan deleted the fix-1405 branch July 29, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelwedler manuelwedler manuelwedler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Sourcify Public
Status: COMPLETED
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update contract_deployments after storing a better match with creatorTx information
2 participants
@marcocastignoli @manuelwedler