Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chain 13337 #1134

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Add chain 13337 #1134

merged 3 commits into from
Aug 10, 2023

Conversation

dfenstermaker
Copy link
Contributor

@dfenstermaker dfenstermaker commented Aug 8, 2023

Add New Chain

Thanks for your pull request to add a new support in Sourcify.

If you haven't done so, please follow the instructions on how to request chain support in docs.

Please check the following items before submitting your pull request.

Checklist

  • The branch is named as add-chain-<chainId>.
  • I haven't modified the chains.json file directly.
  • In sourcify-chains.ts file
    • I've set supported: true.
    • I've set monitored: false.
    • I haven't added an rpc field but the one in chains.json is used (if not, please explain why).
  • I've added a test in chain-tests.js file.
  • test-new-chain test in Circle CI is passing.

View in Huly HI-631

@kuzdogan
Copy link
Member

kuzdogan commented Aug 9, 2023

The problem was that the chain 13337 was not in the old chains.json file. Updated the chains.json.

@kuzdogan
Copy link
Member

kuzdogan commented Aug 9, 2023

Ok now I see the contract gets only partially verified. Do you have a perfect match in hand or if this is a testnet can you maybe deploy the standard contracts as in the docs?

@dfenstermaker
Copy link
Contributor Author

@kuzdogan I cannot deploy contracts on this chain or any of the others I am about to add here. This contract I am adding is standard on our deploys tho thus I am trying to get this it working

@kuzdogan
Copy link
Member

kuzdogan commented Aug 9, 2023

Ok, I see. Let me add an option for a partial verification in the test function then.

@kuzdogan kuzdogan merged commit ee42ba2 into ethereum:staging Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants