Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FTM Fantom Opera mainnet 250 #1131

Merged
merged 8 commits into from
Aug 9, 2023
Merged

Conversation

Kharabet
Copy link
Contributor

@Kharabet Kharabet commented Aug 7, 2023

Add New Chain 250

Thanks for your pull request to add a new support in Sourcify.

If you haven't done so, please follow the instructions on how to request chain support in docs.

Please check the following items before submitting your pull request.

Checklist

  • The branch is named as add-chain-<chainId>.
  • I haven't modified the chains.json file directly.
  • In sourcify-chains.ts file
    • I've set supported: true.
    • I've set monitored: false.
    • I haven't added an rpc field but the one in chains.json is used (if not, please explain why).
  • I've added a test in chain-tests.js file.
  • test-new-chain test in Circle CI is passing.

View in Huly HI-633

@Kharabet
Copy link
Contributor Author

Kharabet commented Aug 7, 2023

It says it can't fetch GSN/Context.sol. But here it is https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v2.5.0/contracts/GSN/Context.sol

image

@kuzdogan
Copy link
Member

kuzdogan commented Aug 7, 2023

It can't fetch it because there's no GitHub url under the urls of that file. There's only the bzzr hash.

Can you also add those files alongside the test files as well as add them in the verifyContract's sources array?

@Kharabet
Copy link
Contributor Author

Kharabet commented Aug 7, 2023

@kuzdogan any reason it can't see FUSDToken.sol now?

@kuzdogan
Copy link
Member

kuzdogan commented Aug 7, 2023

Hmm from what I can tell the FUSDToken.sol file provided has a different hash (0x430f6a7...) than in the metadata (0xdffa824...). Are you sure these are the original files? If this contract is in a repository somewhere, I can also have a look. Alternatively we can get an already verified contract from https://ftmscan.com/ using the "Import from Etherscan".

@Kharabet
Copy link
Contributor Author

Kharabet commented Aug 7, 2023

Hmm from what I can tell the FUSDToken.sol file provided has a different hash (0x430f6a7...) than in the metadata (0xdffa824...). Are you sure these are the original files? If this contract is in a repository somewhere, I can also have a look. Alternatively we could've gotten an already verified contract from https://ftmscan.com/ using the "Import from Etherscan" but I see it's down.

Ah, I see. in sol file I changed imports so @opnezeppelin files are taken not from github, but locally

I took fantom's stablecoin as a contract for the test https://github.com/Fantom-foundation/Fantom-Fusd

@@ -957,10 +957,15 @@ const sourcifyChainsExtensions: SourcifyChainsExtensionsObject = {
// Edgeware EdgeEVM Mainnet
supported: true,
monitored: false,
contractFetchAddress:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this removal on purpose?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, my fault. as well as some formatting. I will disable my VS code formatter for the workspace and push the changes. Thanks!

@Kharabet
Copy link
Contributor Author

Kharabet commented Aug 7, 2023

@Kharabet
Copy link
Contributor Author

Kharabet commented Aug 7, 2023

@Kharabet
Copy link
Contributor Author

Kharabet commented Aug 7, 2023

@kuzdogan ok, seem it is all good with contracts. Now, fails on puppeteer utils fetch. Can you please take a look when have time?

@Kharabet
Copy link
Contributor Author

Kharabet commented Aug 8, 2023

Hey @kuzdogan, I changed the contract for test: deployed Storage contract on Fantom chain https://ftmscan.com/address/0xc47856bEBCcc2BBB23E7a5E1Ba8bB4Fffa5C5476#code

I guess PR is good to go now

@kuzdogan
Copy link
Member

kuzdogan commented Aug 9, 2023

Thanks a lot for deploying. Good to go now 👍

@kuzdogan kuzdogan merged commit 0c3f331 into ethereum:staging Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants