-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FTM Fantom Opera mainnet 250 #1131
Conversation
It says it can't fetch GSN/Context.sol. But here it is https://github.com/OpenZeppelin/openzeppelin-contracts/blob/v2.5.0/contracts/GSN/Context.sol |
It can't fetch it because there's no GitHub url under the Can you also add those files alongside the test files as well as add them in the |
@kuzdogan any reason it can't see FUSDToken.sol now? |
Hmm from what I can tell the |
Ah, I see. in sol file I changed imports so I took fantom's stablecoin as a contract for the test https://github.com/Fantom-foundation/Fantom-Fusd |
src/sourcify-chains.ts
Outdated
@@ -957,10 +957,15 @@ const sourcifyChainsExtensions: SourcifyChainsExtensionsObject = { | |||
// Edgeware EdgeEVM Mainnet | |||
supported: true, | |||
monitored: false, | |||
contractFetchAddress: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this removal on purpose?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope, my fault. as well as some formatting. I will disable my VS code formatter for the workspace and push the changes. Thanks!
Ok I can have a look at this, if you can enable maintainer access to this PR https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests |
|
one sec, I have an idea what to do. Let me try |
@kuzdogan ok, seem it is all good with contracts. Now, fails on puppeteer utils fetch. Can you please take a look when have time? |
Hey @kuzdogan, I changed the contract for test: deployed Storage contract on Fantom chain https://ftmscan.com/address/0xc47856bEBCcc2BBB23E7a5E1Ba8bB4Fffa5C5476#code I guess PR is good to go now |
Thanks a lot for deploying. Good to go now 👍 |
Add New Chain 250
Thanks for your pull request to add a new support in Sourcify.
If you haven't done so, please follow the instructions on how to request chain support in docs.
Please check the following items before submitting your pull request.
Checklist
add-chain-<chainId>
.supported: true
.monitored: false
.rpc
field but the one in chains.json is used (if not, please explain why).test-new-chain
test in Circle CI is passing.View in Huly HI-633