-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement logging for LibSourcify #1082
Conversation
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## staging #1082 +/- ##
===========================================
- Coverage 79.27% 74.59% -4.69%
===========================================
Files 55 65 +10
Lines 1520 2389 +869
Branches 267 439 +172
===========================================
+ Hits 1205 1782 +577
- Misses 182 379 +197
- Partials 133 228 +95
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There needs to be more work on what to log and on which level to log, but we can work on that later as we see the needs.
Just asking for small changes and clarifications.
Co-authored-by: Kaan Uzdoğan <[email protected]>
Co-authored-by: Kaan Uzdoğan <[email protected]>
setLibSourcifyLoggerLevel
setLibSourcifyLogger
implementingILibSourcifyLogger
use the logger inside lib sourcify with
logError
,logWarn
,logInfo
,logDebug
@kuzdogan we need to decide what to log inside lib-sourcify
View in Huly HI-549