Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chain 61 #1077

Merged
merged 5 commits into from Jul 5, 2023
Merged

Add chain 61 #1077

merged 5 commits into from Jul 5, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jun 23, 2023

Add "New" Chain 61 (Ethereum Classic) and NEW RPC DUE OFFICIAL PRESS RELEASE!

Hey,

Ethereum Classic here

Lets add this beauty to net-list! New RPC set (Here the alert about rpc from official)

Tests done

View in Huly HI-658

@kuzdogan
Copy link
Member

Hi

Please check the PR template and follow the instructions in the docs:

Add New Chain

Thanks for your pull request to add a new support in Sourcify.

If you haven't done so, please follow the instructions on how to request chain support in docs.

Please check the following items before submitting your pull request.

Checklist

  • The branch is named as add-chain-<chainId>.
  • I haven't modified the chains.json file directly.
  • In sourcify-chains.ts file
    • I've set supported: true.
    • I've set monitored: false.
    • I haven't added an rpc field but the one in chains.json is used (if not, please explain why).
  • I've added a test in chain-tests.js file.
  • test-new-chain test in Circle CI is passing.

@ghost
Copy link
Author

ghost commented Jun 23, 2023

@kuzdogan
Hey, all done due instructions and test-new-chain passing. Only one thing - I'm added new rpc. The official link about rpc change - https://ethereumclassic.org/blog/2023-01-04-alert-migrate-your-etc-endpoints-from-ethercluster-to-rivet-by-july-1st-2023

@ghost
Copy link
Author

ghost commented Jun 24, 2023

Anybody home?

@marcocastignoli
Copy link
Member

it would be the best to update the rpc directly in https://github.com/ethereum-lists/chains

@ghost
Copy link
Author

ghost commented Jul 1, 2023

new rpcUrl on https://github.com/ethereum-lists/chains UPDATED.

So guys, why there is NO ethereum classic in https://sourcify.dev/ ui? Choose chain - > No Ethereum classic

@marcocastignoli
@kuzdogan

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -7.38 ⚠️

Comparison is base (a210c1e) 78.88% compared to head (d37824a) 71.51%.

❗ Current head d37824a differs from pull request most recent head a1860be. Consider uploading reports for the commit a1860be to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1077      +/-   ##
===========================================
- Coverage    78.88%   71.51%   -7.38%     
===========================================
  Files           56       66      +10     
  Lines         1539     2394     +855     
  Branches       271      440     +169     
===========================================
+ Hits          1214     1712     +498     
- Misses         189      468     +279     
- Partials       136      214      +78     
Flag Coverage Δ
lib-sourcify 66.19% <ø> (?)
server 74.46% <ø> (-4.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourcify-chains.ts 84.31% <ø> (ø)

... and 18 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kuzdogan kuzdogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please turn off the monitor as stated in the instructions.

Otherwise looks good 👍

@@ -198,6 +198,13 @@ const sourcifyChainsExtensions: SourcifyChainsExtensionsObject = {
monitored: false,
contractFetchAddress: generateEtherscanCreatorTxAPI("56"),
},
"61": {
supported: true,
monitored: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
monitored: true,
monitored: false,

@ghost
Copy link
Author

ghost commented Jul 5, 2023

@kuzdogan done

@kuzdogan kuzdogan merged commit fce2bd0 into ethereum:staging Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants