Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-chain-7001 -- New RPC endpoints and test contracts for ZetaChain Athens3 Testnet #1051

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

CharlieMc0
Copy link
Contributor

@CharlieMc0 CharlieMc0 commented Jun 5, 2023

I am updating the RPC endpoints, verifications contract, and explorer URLs for the Zetachain Athens network.

A PR is pending in the ethereum-lists/chains repo to get the chain.json file updated -

https://github.com/ethereum/sourcify/compare/ethereum:sourcify:staging...zeta-chain:update-chain-7001?template=add-new-chain.md&title=Add+New+Chain+%3CchainId%3E

View in Huly HI-673

@CharlieMc0 CharlieMc0 changed the title Updated RPC endpoints and test contract for athens3 update-chain-7001 -- New RPC endpoints and test contracts for ZetaChain Athens3 Testnet Jun 5, 2023
@marcocastignoli
Copy link
Member

Hello @CharlieMc0, please remove your edits to src/chains.json. We'll update the file once your PR on ethereum-lists/chains is approved. Thanks.

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -7.49 ⚠️

Comparison is base (d449b7a) 77.31% compared to head (8811f4e) 69.82%.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1051      +/-   ##
===========================================
- Coverage    77.31%   69.82%   -7.49%     
===========================================
  Files           31       40       +9     
  Lines         1450     2270     +820     
  Branches       266      432     +166     
===========================================
+ Hits          1121     1585     +464     
- Misses         191      468     +277     
- Partials       138      217      +79     
Flag Coverage Δ
lib-sourcify 66.70% <ø> (?)
server 71.58% <ø> (-5.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourcify-chains.ts 84.94% <ø> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@CharlieMc0
Copy link
Contributor Author

Removed edits to chains.json and my PR on ethereum-lists/chains#2955 has been merged.

@kuzdogan
Copy link
Member

Why are you updating services/core/build/sourcify-chains.js?

Just updated the chains.json on staging. Can you please merge or rebase and remove the changes at the above file?

@CharlieMc0
Copy link
Contributor Author

I think i committed it on accident. I reverted it so now the only change is the verification contract. We regenesis'd the testnet so the contract had to be redeployed

@kuzdogan
Copy link
Member

Ran the tests locally, merging.

@kuzdogan kuzdogan merged commit 268792e into ethereum:staging Jun 13, 2023
@billyyang423
Copy link

Hello @kuzdogan I updated our RPC endpoints for chain 7001 in this PR so we don't have verification support removed for this chain. If you could please help review it that would be great! Thank you! Let me know if there are any issues.

@kuzdogan
Copy link
Member

Hey @billyyang423 I'm not a maintainer of that repo so it needs to be merged by a maintainer. Just lmk when it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants