Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chain 96 (Bitkub Chain) #1047

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Conversation

ppanya
Copy link
Contributor

@ppanya ppanya commented Jun 2, 2023

Adds support for chain 96 - Bitkub Chain

View in Huly HI-680

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -7.45 ⚠️

Comparison is base (9ff3a04) 77.31% compared to head (d96c4bd) 69.86%.

Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1047      +/-   ##
===========================================
- Coverage    77.31%   69.86%   -7.45%     
===========================================
  Files           31       40       +9     
  Lines         1450     2270     +820     
  Branches       266      431     +165     
===========================================
+ Hits          1121     1586     +465     
- Misses         191      468     +277     
- Partials       138      216      +78     
Flag Coverage Δ
lib-sourcify 66.82% <ø> (?)
server 71.58% <ø> (-5.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/sourcify-chains.ts 84.94% <ø> (ø)

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kuzdogan
Copy link
Member

kuzdogan commented Jun 2, 2023

Merging the Testnet PR caused a conflict. Can you please resolve?

@ppanya
Copy link
Contributor Author

ppanya commented Jun 2, 2023

sure, just in a sec

@ppanya
Copy link
Contributor Author

ppanya commented Jun 2, 2023

@kuzdogan resolved

@kuzdogan kuzdogan merged commit 3adb2c7 into ethereum:staging Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants