Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save solc-js executables after download #954

Closed
kuzdogan opened this issue Mar 9, 2023 · 0 comments · Fixed by #964
Closed

Save solc-js executables after download #954

kuzdogan opened this issue Mar 9, 2023 · 0 comments · Fixed by #964
Assignees

Comments

@kuzdogan
Copy link
Member

kuzdogan commented Mar 9, 2023

Currently when the compiler falls back to solc-js instead of binaries, it always downloads them and doesn't save.

Save the solc-js files to avoid downloading each time. This means the solc-js handler first checks if the file exists and downloads otherwise.

View in Huly HI-375

@marcocastignoli marcocastignoli self-assigned this Mar 14, 2023
marcocastignoli added a commit that referenced this issue Mar 14, 2023
* download the solcjs binary like the amd one
* use the downloaded binary through setupMethods
* check existing binaries before downloading new one
marcocastignoli added a commit that referenced this issue Mar 15, 2023
* download the solcjs binary like the amd one
* use the downloaded binary through setupMethods
* check existing binaries before downloading new one
kuzdogan pushed a commit that referenced this issue Mar 16, 2023
* fixe #954 force solcjs to use the setupMethods api
* download the solcjs binary like the amd one
* use the downloaded binary through setupMethods
* check existing binaries before downloading new one

* fix #955 automatic fetch of solc compiler for the right platform
* if platform is not supported fallback on solcjs
* ! needs to be tested

* merge functions to download solc and solcjs

* fix conflicts after rebasing onto staging

* * add comment to fetchAndSaveSolc
* fix typo
* add missing expect in tests
* add test for solcjs

* fail useCompiler test with a meaningful error message

* test "Should compile with solc binary" on linux-platform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants