[ui]: Lookup does not include deprecated chains

[kuzdogan]

Because we deleted the deprecated chains (Ropsten, Kovan etc.) the UI does not ask for verified contracts (/checkAllByAddress) for them. Even if we have deprecated them, we should include them and mark them supported: false. The underlying reason is not with the UI per se, but with sourcify-chains.ts.

Also in the future, it might make sense to have an endpoint to look for all chains without checkByAddress requiring all chains to be passed.

Example

0x136f0cC844A873B61E4adF46f885D4e112D3fC20 can be seen in the repo.sourcify.dev but in the UI it is not found

_{View in Huly HI-406}

[marcocastignoli]

Do we have a complete list of the deleted chains? If not I can make it looking at the sourcify-chains file's history

[kuzdogan]

No we haven't stored it anywhere.

AFAIK it is only the deprecated Ethereum testnets. Instead of looking all the way to the file history, you can check the chainId's that exist in the file system (full_match and partial_match) but not in sourcify-chains.ts. For example Kovan (42) and Ropsten (3).

[marcocastignoli]

I compared the production repo with the sourcify-chains.ts, these are the networks that were removed:

• 421611
• 69
• 42
• 3

[kuzdogan]

Looks like this broke a test

[marcocastignoli]

Looks like this broke a test

which test? circleci's node-16-test are working

[kuzdogan]

The tests were broken with 2c54874 but seems to be back with 35be29d.

However I see an extra "View in Sourcify Repository" link to chainId=0

See https://staging.sourcify.dev/#/lookup/0x1F98431c8aD98523631AE4a59f267346ea31F984

[marcocastignoli]

Is not what we wanted with #869 ?

[kuzdogan]

It is what we want if it is create2 verified.

I see the link even if the contract is not create2 verified

[marcocastignoli]

Oh sorry I didn't noticed it, now it's clear

[marcocastignoli]

fixed with the commit f464ef6