Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript upgrade needed for lib-sourcify #1010

Closed
marcocastignoli opened this issue May 2, 2023 · 1 comment
Closed

Typescript upgrade needed for lib-sourcify #1010

marcocastignoli opened this issue May 2, 2023 · 1 comment
Assignees

Comments

@marcocastignoli
Copy link
Member

marcocastignoli commented May 2, 2023

It seems like abitype requires a newer version of typescript.

marcocastignoli@locahost sourcify % npx lerna bootstrap
lerna notice cli v3.22.1
lerna info Bootstrapping 5 packages
lerna info Installing external dependencies
lerna ERR! npm install --no-package-lock exited 1 in '@ethereum-sourcify/lib-sourcify'
lerna ERR! npm install --no-package-lock stderr:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @ethereum-sourcify/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/typescript
npm ERR!   dev typescript@"^4.9.4" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@">=5.0.4" from [email protected]
npm ERR! node_modules/abitype
npm ERR!   abitype@"^0.8.0" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/marcocastignoli/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/marcocastignoli/.npm/_logs/2023-05-02T09_45_44_532Z-debug-0.log

lerna ERR! npm install --no-package-lock exited 1 in '@ethereum-sourcify/lib-sourcify'
lerna WARN complete Waiting for 2 child processes to exit. CTRL-C to exit immediately.

View in Huly HI-402

@marcocastignoli marcocastignoli self-assigned this May 2, 2023
@marcocastignoli
Copy link
Member Author

marcocastignoli commented May 2, 2023

@kuzdogan just double-checking with you if you can spot potential problem upgrading typescript.

  • lib-sourcify and server tests are passing

marcocastignoli added a commit that referenced this issue May 3, 2023
* fix compatibility issue with typescript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant